Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Convert relevant columns of fields summary pandas data from str to floats #4595

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

lorenzovecchietti
Copy link
Contributor

No description provided.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.53%. Comparing base (7104268) to head (211462f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4595      +/-   ##
==========================================
+ Coverage   81.51%   81.53%   +0.01%     
==========================================
  Files         110      110              
  Lines       53772    53776       +4     
==========================================
+ Hits        43834    43847      +13     
+ Misses       9938     9929       -9     

@lorenzovecchietti lorenzovecchietti marked this pull request as ready for review April 29, 2024 13:12
@Samuelopez-ansys
Copy link
Member

@lorenzovecchietti Why do not leave the default pandas? And then in your workflow apply this conversion?

@lorenzovecchietti
Copy link
Contributor Author

lorenzovecchietti commented Apr 30, 2024

Those columns will always contain numbers (unit is specified by the entity column)
At the moment they are strings just because the dataframe is parsed from csv, not because of any "intrinsic" reason.

@lorenzovecchietti lorenzovecchietti merged commit 4293541 into main Apr 30, 2024
15 checks passed
@lorenzovecchietti lorenzovecchietti deleted the field_summary_enhancement branch April 30, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants