Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix active design selection behavior for Emit designs" #4616

Closed

Conversation

myoung301
Copy link
Contributor

Reverts #4587

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@codecov-commenter
Copy link

codecov-commenter commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.51%. Comparing base (388de1d) to head (0ecf652).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4616      +/-   ##
==========================================
+ Coverage   81.50%   81.51%   +0.01%     
==========================================
  Files         110      110              
  Lines       53845    53848       +3     
==========================================
+ Hits        43885    43894       +9     
+ Misses       9960     9954       -6     

@SMoraisAnsys
Copy link
Collaborator

@myoung301 Is there a reason to revert those changes ?

@myoung301
Copy link
Contributor Author

@myoung301 Is there a reason to revert those changes ?

We noticed a test failure after the original PR. I created a couple draft PRs to evaluate different approaches. The other approach was successful and allowed the fix to remain so I will abandon this PR and publish the other.

@myoung301
Copy link
Contributor Author

Found another approach that worked and left the fix intact.

@myoung301 myoung301 closed this May 2, 2024
@myoung301 myoung301 deleted the revert-4587-myoung301-fix-emit-use-active-project branch May 2, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants