FEAT: improve edit_external_circuit #4696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
gmalinve
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4696 +/- ##
==========================================
- Coverage 80.38% 80.38% -0.01%
==========================================
Files 122 122
Lines 55089 55095 +6
==========================================
+ Hits 44285 44288 +3
- Misses 10804 10807 +3 |
Samuelopez-ansys
previously approved these changes
May 20, 2024
PipKat
reviewed
May 20, 2024
PipKat
reviewed
May 20, 2024
PipKat
reviewed
May 20, 2024
SMoraisAnsys
previously approved these changes
May 20, 2024
gmalinve
dismissed stale reviews from SMoraisAnsys and Samuelopez-ansys
via
d5e8735
Co-authored-by: Kathy Pippert <[email protected]>
|
@SMoraisAnsys I don't see your comment :) where did you put it? |
SMoraisAnsys
previously approved these changes
May 21, 2024
There was a problem hiding this comment.
LGTM, this time the minor changes have been added !
@gmalinve Thanks for notifying me of this issue (dunno why but even now I had to click 5 times on "Add review" to eventually add my comment)
Co-authored-by: Sébastien Morais <[email protected]>
PipKat
reviewed
May 21, 2024
SMoraisAnsys
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.