-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Add discovery link function #4705
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4705 +/- ##
==========================================
- Coverage 83.47% 83.45% -0.02%
==========================================
Files 121 121
Lines 54855 54868 +13
==========================================
Hits 45792 45792
- Misses 9063 9076 +13 |
for more information, see https://pre-commit.ci
@IreneWoyna I posted a couple of general questions about the implementation but I was wondering.. why did you put it in Primitives? |
Because that's where the spaceclaim link is, there's no further intelligence behind that decision :D |
- corrected Discovery version check - added link disconnection
for more information, see https://pre-commit.ci
@SMoraisAnsys @Samuelopez-ansys to make pass the new test we need Workbench to be installed in the VM. Would this be possible? |
8360126
No description provided.