Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Add discovery link function #4705

Merged
merged 29 commits into from
Aug 7, 2024
Merged

FEAT: Add discovery link function #4705

merged 29 commits into from
Aug 7, 2024

Conversation

IreneWoyna
Copy link
Contributor

No description provided.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@IreneWoyna IreneWoyna self-assigned this May 21, 2024
@IreneWoyna IreneWoyna linked an issue May 21, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented May 21, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.45%. Comparing base (9d2f50a) to head (d958d3e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4705      +/-   ##
==========================================
- Coverage   83.47%   83.45%   -0.02%     
==========================================
  Files         121      121              
  Lines       54855    54868      +13     
==========================================
  Hits        45792    45792              
- Misses       9063     9076      +13     

@IreneWoyna IreneWoyna marked this pull request as ready for review May 24, 2024 07:45
@IreneWoyna IreneWoyna requested review from gmalinve and Alberto-DM May 24, 2024 07:45
@gmalinve
Copy link
Contributor

@IreneWoyna I posted a couple of general questions about the implementation but I was wondering.. why did you put it in Primitives?

@IreneWoyna
Copy link
Contributor Author

@IreneWoyna I posted a couple of general questions about the implementation but I was wondering.. why did you put it in Primitives?

Because that's where the spaceclaim link is, there's no further intelligence behind that decision :D

pyaedt/modeler/cad/Primitives.py Outdated Show resolved Hide resolved
pyaedt/modeler/cad/Primitives.py Outdated Show resolved Hide resolved
pyaedt/modeler/cad/Primitives.py Outdated Show resolved Hide resolved
pyaedt/modeler/cad/Primitives.py Show resolved Hide resolved
@gmalinve
Copy link
Contributor

@SMoraisAnsys @Samuelopez-ansys to make pass the new test we need Workbench to be installed in the VM. Would this be possible?

@IreneWoyna

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) August 7, 2024 05:54
pyaedt/modeler/cad/Primitives.py Outdated Show resolved Hide resolved
pyaedt/modeler/cad/Primitives.py Outdated Show resolved Hide resolved
SMoraisAnsys
SMoraisAnsys previously approved these changes Aug 7, 2024
@gmalinve gmalinve dismissed stale reviews from SMoraisAnsys and Samuelopez-ansys via 8360126 August 7, 2024 12:12
@Samuelopez-ansys Samuelopez-ansys merged commit 481fcbc into main Aug 7, 2024
44 of 45 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the add/disco_link branch August 7, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Discovery Link
7 participants