FIX: HFSS Setup error #5618 #5619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
\ansys\aedt\core\modules\setup_templates.py - Change autosweep default from "LinearStep" to "LinearCount" to match the default behavior of HFSS. - Use "RangeCount": 501 \ansys\aedt\core\hfss.py - Update docstring errors for create_setup() \ansys\aedt\core\application.py - Change default setup from 1 to 0 for HFSS where appropriate. \ansys\aedt\core\application\analysis.py - Correct an error that would always use an auto-generated name for the setup.
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5619 +/- ##
==========================================
- Coverage 85.27% 85.26% -0.01%
==========================================
Files 152 152
Lines 60939 60939
==========================================
- Hits 51963 51960 -3
- Misses 8976 8979 +3 |
- The docstring for Hfss.create_setup had an error. The text "HFSSDrivenDefault" is not a valid argument for setup_type. - Updated test_02_hfss_export_results by adding the argument setup_type which was not present previously. - Added a few more assert statements to that test. - Added the solve frequency as a variable that is retrieved from the setup since this is re-used multiple times. - Added a test for HFSS setups in test_20_HFSS.py
For more information, see https://pre-commit.ci
- Replace deprecated create_discrete_sweep() with create_frequency_sweep()
- choke_designer.py uses the "HFSSDriven" setup type. This must must be passed explicitly with the "setup_type" argument.
…o fix/5618_hfss_default_setup
Some changes were made inadvertently.
A 2nd attempt to create a setup name with the same name would cause an error in AEDT. Now check if the setup exists and assign a unique name if the name is used..
|
@Devin-Crawford I think the default setup should be 1, because Auto setup corresponds to 0, and Auto setup is less used than the "Advanced" setup. |
Samuelopez-ansys
previously approved these changes
Jan 13, 2025
Samuelopez-ansys
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #5618
Description
\ansys\aedt\core\modules\setup_templates.py\ansys\aedt\core\hfss.py\ansys\aedt\core\application.py\ansys\aedt\core\application\analysis.pyIssue linked
Close #5618
Checklist