Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR: General clean up of modeler modules #5647

Merged
merged 12 commits into from
Jan 15, 2025

Conversation

SMoraisAnsys
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys commented Jan 11, 2025

Description

As title says, various changes to cleanup variable names, methods implementation, logging, removing assert in non test code, ...

Issue linked

Associated to #5504

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link

codecov bot commented Jan 11, 2025

Codecov Report

Attention: Patch coverage is 89.30041% with 26 lines in your changes missing coverage. Please review.

Project coverage is 85.21%. Comparing base (a5cbc5e) to head (b141f5e).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5647      +/-   ##
==========================================
- Coverage   85.25%   85.21%   -0.04%     
==========================================
  Files         152      152              
  Lines       61012    60719     -293     
==========================================
- Hits        52015    51742     -273     
+ Misses       8997     8977      -20     

Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys Samuelopez-ansys merged commit 00c3a82 into main Jan 15, 2025
43 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the refactor/general-cleanup branch January 15, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants