-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REFACTOR: General clean up of modeler modules #5647
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5647 +/- ##
==========================================
- Coverage 85.25% 85.21% -0.04%
==========================================
Files 152 152
Lines 61012 60719 -293
==========================================
- Hits 52015 51742 -273
+ Misses 8997 8977 -20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
As title says, various changes to cleanup variable names, methods implementation, logging, removing assert in non test code, ...
Issue linked
Associated to #5504
Checklist