Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Convert near field list name order #5666

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

Samuelopez-ansys
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys commented Jan 16, 2025

Description

Depeding on OS, the file list order could change, and the files could contain different size data. With this PR, if the field does not contain information, it is filled with a 0 value, because it means that there is no field value at this field component.

Issue linked

Close #5664

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@Samuelopez-ansys Samuelopez-ansys changed the title Fix list name order issue Fix: Convert near field list name order Jan 16, 2025
@github-actions github-actions bot added the bug Something isn't working label Jan 16, 2025
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.22%. Comparing base (11e2fdd) to head (e24c9cd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5666      +/-   ##
==========================================
- Coverage   85.23%   85.22%   -0.02%     
==========================================
  Files         154      154              
  Lines       60764    60764              
==========================================
- Hits        51795    51787       -8     
- Misses       8969     8977       +8     

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) January 16, 2025 13:18
@Samuelopez-ansys Samuelopez-ansys changed the title Fix: Convert near field list name order FIX: Convert near field list name order Jan 16, 2025
@Samuelopez-ansys Samuelopez-ansys merged commit b2991fa into main Jan 16, 2025
42 of 43 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the fix/issue_5664 branch January 16, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug located in test_47_convert_near_field
2 participants