Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Conformal waveport extension bug fix #5688

Merged
merged 5 commits into from
Jan 27, 2025
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,6 @@ def main(extension_args):
"selected the correct mounting side. The selected side must "
"must contain explicit voids with pad-stack instances inside.",
)
signal_nets = list(edb.nets.signal.keys())
edb.close()
time.sleep(1)

Expand All @@ -259,24 +258,13 @@ def main(extension_args):
hfss.solution_type = "Modal"

# Deleting dielectric objects
[obj.delete() for obj in hfss.modeler.solid_objects if obj.material_name in hfss.modeler.materials.dielectrics]
for obj in [
obj for obj in hfss.modeler.solid_objects if obj.material_name in hfss.modeler.materials.dielectrics
]: # pragma no cover
obj.delete()
svandenb-dev marked this conversation as resolved.
Show resolved Hide resolved

# creating ports
sheets_for_ports = hfss.modeler.sheet_objects
terminal_faces = []
terminal_objects = [obj for obj in hfss.modeler.object_list if obj.name in signal_nets]
for obj in terminal_objects:
if mounting_side_variable == "bottom":
face = obj.bottom_face_z
else:
face = obj.top_face_z
terminal_face = hfss.modeler.create_object_from_face(face.id, non_model=False)
hfss.assign_perfecte_to_sheets(terminal_face.name)
name = obj.name
terminal_faces.append(terminal_face)
obj.delete()
terminal_face.name = name
for sheet in sheets_for_ports:
for sheet in hfss.modeler.sheet_objects: # pragma no cover
svandenb-dev marked this conversation as resolved.
Show resolved Hide resolved
hfss.wave_port(assignment=sheet.id, reference="GND", terminals_rename=False)

# create 3D component
Expand Down
Loading