Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: New extension version manager #5702

Merged
merged 29 commits into from
Feb 7, 2025
Merged

FEAT: New extension version manager #5702

merged 29 commits into from
Feb 7, 2025

Conversation

hui-zhou-a
Copy link
Contributor

@hui-zhou-a hui-zhou-a commented Jan 29, 2025 •
edited
Loading

Description

New extension Version manager.

Issue linked

Close #5732

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@hui-zhou-a hui-zhou-a linked an issue Jan 29, 2025 that may be closed by this pull request
Add an extension to manage pyaedt pyedb versions #5703
Closed
@codecov Codecov
Copy link

codecov bot commented Jan 29, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 344 lines in your changes missing coverage. Please review.

Project coverage is 84.75%. Comparing base (d4e2859) to head (6644169).
Report is 7 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5702      +/-   ##
==========================================
+ Coverage   81.55%   84.75%   +3.20%     
==========================================
  Files         156      157       +1     
  Lines       61181    61563     +382     
==========================================
+ Hits        49894    52180    +2286     
+ Misses      11287     9383    -1904

@Samuelopez-ansys
Copy link
Member

@hui-zhou-a This extension is great! But could you please use the same style than the others? I think you can see the choke designer one which has already multi tabs like this one and probably it will be easier for you to adapt.

The icon of the app when it is opened, is not the PyAnsys logo, and to respect consistency with the other extension you should also import it.

In summary, I think you could check the choke_designer toolkit and try to adapt the style

@hui-zhou-a hui-zhou-a changed the title New extension version manager FEAT: New extension version manager Feb 3, 2025
@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) February 4, 2025 17:01
SMoraisAnsys
SMoraisAnsys requested changes Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some minor comments. Thanks for the contribution @hui-zhou-a !

doc/source/User_guide/pyaedt_extensions_doc/project/version_manager.rst Outdated Show resolved Hide resolved
src/ansys/aedt/core/workflows/project/version_manager.py Outdated Show resolved Hide resolved
src/ansys/aedt/core/workflows/project/version_manager.py Outdated Show resolved Hide resolved
src/ansys/aedt/core/workflows/project/version_manager.py Outdated Show resolved Hide resolved
src/ansys/aedt/core/workflows/project/version_manager.py Outdated Show resolved Hide resolved
src/ansys/aedt/core/workflows/project/version_manager.py Show resolved Hide resolved
@hui-zhou-a
Copy link
Contributor Author

@SMoraisAnsys I fixed what I can, please review again.

SMoraisAnsys
SMoraisAnsys previously approved these changes Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but have a look at my concern please.
Just in case we ever face that behavior !

doc/source/User_guide/pyaedt_extensions_doc/project/version_manager.rst Outdated Show resolved Hide resolved
src/ansys/aedt/core/workflows/project/version_manager.py Show resolved Hide resolved
@wiz-inc-572fc38784
Copy link

wiz-inc-572fc38784 bot commented Feb 7, 2025 •
edited
Loading

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities
Data Finding Sensitive Data 1 Info
Secret Finding Secrets
IaC Misconfiguration IaC Misconfigurations
Total 1 Info

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

SMoraisAnsys
SMoraisAnsys previously approved these changes Feb 7, 2025
View reviewed changes
@Samuelopez-ansys Samuelopez-ansys merged commit 01b93eb into main Feb 7, 2025
42 of 43 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the new-extension-version-manager branch February 7, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxJPRey MaxJPRey MaxJPRey left review comments

@SMoraisAnsys SMoraisAnsys SMoraisAnsys approved these changes

@Samuelopez-ansys Samuelopez-ansys Awaiting requested review from Samuelopez-ansys

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need an extension to manage PyAEDT/PyEDB version Add an extension to manage pyaedt pyedb versions
4 participants
@hui-zhou-a @Samuelopez-ansys @MaxJPRey @SMoraisAnsys