-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding documentation about secrets and tokens #311
base: main
Are you sure you want to change the base?
Conversation
The core of the PR is done. Two things:
Feel free to review for format and approach. |
DO NOT MERGE YET |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Minor comments
| Full control of codespaces. | | | ||
+-------------------------------------------------------------------------------------+------------------------+ | ||
| **codespace:secrets** | |:x:| | | ||
| Ability to create, read, update, and delete codespace secrets. | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solve Vale issues. You will need to add both Codespace
and codespace
. Same goes for Codespaces
and codespaces
.
************** | ||
|
||
The value of the ``PYPI_TOKEN`` token is unique for each repository. | ||
This token is used for authentication when uploading libraries to the public PyPI index. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ansys/pyansys-core We could specify/remember how to get this token maybe. I don't know if it is relevant here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea....
``TWINE_TOKEN`` | ||
*************** | ||
|
||
The ``TWINE_TOKEN`` token is used for authentication when uploading libraries to PyPI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@germa89 @RobPasMue I would specify the difference with the PYPI_TOKEN
described above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not super convinced of its difference.
~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
+-------------------------------------+------------------------------------+---------------------------------------+-------------------------------------------+----------------------------------------------------------------------------------------------+ | ||
| **Secret** | **Repository access** | **Token** | **Value** | **Description** | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| **Secret** | **Repository access** | **Token** | **Value** | **Description** | | |
| **Secret** | **Repository access** | **Token** | **Value** | **description** | |
| | A user's followers. | | | ||
+----------------------------------------------------------------+----------------------------------------+ | ||
| | **GPG keys** | No access | | ||
| | View and manage a user's GPG keys. | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will users know what a GPG key is? I don't! (Thank goodness for Google! Let readers search for an answer if they are clueless like me!
| **read:audit_log** | |:x:| | | ||
| Read access of audit log. | | | ||
+-------------------------------------------------------------------------------------+------------------------+ | ||
| **codespace** | |:x:| | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, codespace is lower case here in this section, if this influences your response to the capitalization question posed earlier?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely Github needs a Kathy.
I need to update this yes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to go with "C"odespace(s)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@germa89 Virtually all stye guides say not to use (s) but rather to use the plural form instead.
``HUGO_THEME_TOKEN`` | ||
******************** | ||
|
||
The ``HUGO_THEME_TOKEN`` token is used to ... # todo: to be added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want the unfinished stuff visible in the public doc, do we?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No no... in fact, this part needs to be deleted. Because it is not used by (almost) any repo.
Co-authored-by: Roberto Pastor Muela <[email protected]> Co-authored-by: Maxime Rey <[email protected]> Co-authored-by: Kathy Pippert <[email protected]>
This PR aims to document the usage of
secrets
andtokens
in the orgs.It add the following sections:
The idea is to have
secrets
andtokens
.secrets
can be used to storetokens
, in that case, the secrets table will have a "value" pointing to the correspondingtoken
. Remember thattokens
can have names (and descriptions), and we should use that to identify thetokens
rather than thesecret
itself.One I have access to the bot, I will have access to the list of permissions of each bot
tokens
. Then I will fill thetoken
table.