Add math tutorials to the main tutorials branch #1910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisaFelixSalles
changed the base branch from
master
to
doc/new-tutorials-section
|
@luisaFelixSalles can we scroll down in the out section here? |
|
It seems there mismatches between code and output How come? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## doc/new-tutorials-section #1910 +/- ##
=============================================================
- Coverage 88.50% 88.44% -0.07%
=============================================================
Files 89 89
Lines 10251 10251
=============================================================
- Hits 9073 9066 -7
- Misses 1178 1185 +7 |
PProfizi
reviewed
Nov 19, 2024
Comment on lines
7
to
10
| .. |Field| replace:: :class:`Field<ansys.dpf.core.field.Field>` | ||
| .. |Fields| replace:: :class:`Field<ansys.dpf.core.field.Field>` | ||
| .. |FieldsContainer| replace:: :class:`FieldsContainer<ansys.dpf.core.field.Field>` | ||
| .. |FieldsContainers| replace:: :class:`FieldsContainer<ansys.dpf.core.field.Field>` |
There was a problem hiding this comment.
@luisaFelixSalles is that something we could make common somewhere?
There was a problem hiding this comment.
Hm yes we can make it in a separate file and include it in the beginning of each tutorial. But then it would put references we don't use in some tutorials. Idk if that ok ?
Yes we can, I think is just not in the screenshot |
luisaFelixSalles
force-pushed
the
tutorials/math/firsts-math-tutorials
branch
from
ce9b1fc to
cd37263
Compare
luisaFelixSalles
force-pushed
the
tutorials/math/firsts-math-tutorials
branch
from
4a1bf3b to
0b7935b
Compare
luisaFelixSalles
force-pushed
the
doc/new-tutorials-section
branch
from
576cd9f to
627c2de
Compare
luisaFelixSalles
force-pushed
the
tutorials/math/firsts-math-tutorials
branch
from
4606b6a to
939a805
Compare
jorgepiloto
reviewed
Dec 23, 2024
|
|
||
| .. tab-item:: Fields | ||
|
|
||
| Create the Fields by defining: |
There was a problem hiding this comment.
Maybe use lowercase here or the |Field| option?
Suggested change
| Create the Fields by defining: | |
| Create the fields by defining: |
jorgepiloto
reviewed
Dec 23, 2024
jorgepiloto
reviewed
Dec 23, 2024
| - The entities ids and location. Thus, the |Field| scoping | ||
|
|
||
| - If not specified, the location is *'nodal'* by default. | ||
| - Each entity (here, the nodes) must have a |Scoping| id. The ids allows DPF to apply an operator on the |
There was a problem hiding this comment.
Suggested change
| - Each entity (here, the nodes) must have a |Scoping| id. The ids allows DPF to apply an operator on the | |
| - Each node must have a |Scoping| id. The ids allows DPF to apply an operator on the |
jorgepiloto
reviewed
Dec 23, 2024
| # Import the math operators module | ||
| from ansys.dpf.core.operators import math as maths | ||
|
|
||
| Create the Fields by intanciating the |Field| object. |
There was a problem hiding this comment.
Suggested change
| Create the Fields by intanciating the |Field| object. | |
| Create the fields by intanciating the |Field| object. |
jorgepiloto
reviewed
Dec 23, 2024
Co-authored-by: Jorge Martínez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the tutorials of the math section
List of tutorials:
Preview on how it renders:
Mathematics section main page
Basic maths