Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remedy broken api documentation references #2006

Merged
merged 6 commits into from
Jan 14, 2025

Conversation

moe-ad
Copy link
Contributor

@moe-ad moe-ad commented Jan 10, 2025

This closes #1980.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.51%. Comparing base (a1bfa92) to head (ea90340).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2006      +/-   ##
==========================================
+ Coverage   88.43%   88.51%   +0.08%     
==========================================
  Files          89       90       +1     
  Lines       10267    10269       +2     
==========================================
+ Hits         9080     9090      +10     
+ Misses       1187     1179       -8     

@moe-ad moe-ad requested review from jorgepiloto and removed request for jorgepiloto January 13, 2025 09:51
@moe-ad moe-ad marked this pull request as ready for review January 14, 2025 10:39
Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we pass the -n flag in the CI/CD line that is executing the make command?

@moe-ad
Copy link
Contributor Author

moe-ad commented Jan 14, 2025

Done.

@moe-ad moe-ad merged commit c95bb99 into master Jan 14, 2025
46 checks passed
@moe-ad moe-ad deleted the fix/remedy-apidocumentation-references branch January 14, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix potentially broken references in the documentation
2 participants