-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add documentation build environment to tox.ini #2015
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2015 +/- ##
==========================================
- Coverage 88.50% 88.45% -0.06%
==========================================
Files 90 90
Lines 10269 10269
==========================================
- Hits 9089 9083 -6
- Misses 1180 1186 +6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggesting to implement a clean
and links
environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, @moe-ad. Would it be possible to have the commands_post
at [testenv]
level? That would apply it for every environment, right?
@jorgepiloto Yes, indeed, that is possible at the One problem is when you want to run some environments in parallel, the nature of what we are doing in commands_pre/post for PyDPF means that environments that finish executing earlier will try to kill the processes of currently running environments. Another problem even in a sequential run is this:
And the first workflow is desired in the case of PyDPF. |
Thanks for the detailed explanation, @moe-ad. Then, feel free to merge when ready. |
As the title states. This closes #2011.