-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: use tox in ci #2031
base: master
Are you sure you want to change the base?
ci: use tox in ci #2031
Conversation
Moving to "Ready for review" so I can observe workflow runs. |
452c771
to
2d7b82b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2031 +/- ##
==========================================
- Coverage 88.55% 86.52% -2.04%
==========================================
Files 90 90
Lines 10225 10225
==========================================
- Hits 9055 8847 -208
- Misses 1170 1378 +208 |
5f45198
to
f766ee6
Compare
f766ee6
to
6c010c6
Compare
a2f6f53
to
99072f7
Compare
d3ac598
to
1e5c237
Compare
1e5c237
to
0ea6e4a
Compare
Tests run fine now but overall takes twice as long as current CI workflow. But at least we are now benefitting from the fact that each testing environment is clearly isolated, and random PyDPF test failures should occur sparingly in this case. |
This is great news, @moe-ad. Let's give it a try to ' tox-uv' plugin, in that case. Just to make sure the bottle neck is now Tox installing all the necessary dependencies for every environment. |
pytest-xdist seems problematic in retro versions. May have to remove it for those. |
a7c783f
to
78a278b
Compare
Related to #296