Skip to content

Commit

Permalink
Merge pull request #54 from ansys-internal/create_resistor_on_pin
Browse files Browse the repository at this point in the history
test siwave create resistor on pin passed + component.name property a…
  • Loading branch information
svandenb-dev authored Nov 6, 2023
2 parents 77e284b + 9a26bcb commit 8c58262
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 3 deletions.
16 changes: 16 additions & 0 deletions src/pyedb/grpc/edb_core/edb_data/components_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,22 @@ def solder_ball_placement(self):
return self.component_property.solder_ball_property.placement.value
return 2

@property
def name(self):
"""Component name, same as reference designator.
Returns
-------
str
Reference designator name.
"""
return self.refdes

@name.setter
def name(self, name):
if isinstance(name, str):
self.edbcomponent.name = name

@property
def refdes(self):
"""Reference Designator Name.
Expand Down
6 changes: 3 additions & 3 deletions src/pyedb/grpc/siwave.py
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ def _create_terminal_on_pins(self, source):
rlc.l_enabled = False
rlc.r_enabled = True
rlc.r = utility.Value(source.rvalue)
pos_terminal.rlc_boundary_parameters(utility.Rlc)
pos_terminal.rlc_boundary_parameters = rlc
try:
pos_terminal.name = source.name
except:
Expand Down Expand Up @@ -460,9 +460,9 @@ def create_resistor_on_pin(self, pos_pin, neg_pin, rvalue=1, resistor_name=""):
resistor.rvalue = rvalue
if not resistor_name:
resistor_name = "Res_{}_{}_{}_{}".format(
pos_pin.component.name,
pos_pin.component.refdes,
pos_pin.net.name,
neg_pin.component.name,
neg_pin.component.refdes,
neg_pin.net.name,
)
resistor.name = resistor_name
Expand Down

0 comments on commit 8c58262

Please sign in to comment.