first doc compiling #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SMoraisAnsys
previously requested changes
Nov 28, 2023
There was a problem hiding this comment.
On top of my remarks, I would recommend two things:
- check the examples as many of them tend to import
EdbLegacytwice, with different paths. For example:
from pyedb.legacy.edb_core.edb import EdbLegacy
# Ansys release version
ansys_version = "2023.2"
#download and copy the layout file from examples
from pyedb.legacy.edb import EdbLegacy- it seems that you did a copy / paste of src/pyedb/legacy/downloads.py into src/pyedb/misc/downloads.py. So, I would recommend to delete the one in legacy, update the files that depended on it and remember to add pyedb data later on (cf
# TODO: Remove this once pyedb is available in public)
Co-authored-by: SMoraisAnsys <[email protected]>
Co-authored-by: SMoraisAnsys <[email protected]>
Co-authored-by: SMoraisAnsys <[email protected]>
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.