REFACTOR: Optimize Edb initialization for die designs #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several times die designs don't have any component defined. The changes in code are made to reduce the Component initialization time in this case which significantly reduces the Edb initialization time by ~50% especially when there are >100k Groups in the layout. (cherry picked from commit 40cc8f6)
github-actions
bot
added
the
grpc-transition
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #966 +/- ##
==========================================
- Coverage 82.70% 82.68% -0.03%
==========================================
Files 160 160
Lines 21121 21098 -23
==========================================
- Hits 17468 17444 -24
- Misses 3653 3654 +1 |
hui-zhou-a
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicates PR #962 which was created from a fork.
Several times, die designs don't have any component in them.
The code changes made in this PR signifiantly reduces the Component initialization time in this case which thereby reduces the Edb initialization time by ~50% especially when there are >100k Groups in the layout.
This should also speed up EDB initialization time when there are 1000s of components in the design (Ex: Deep trench capacitors in the IC).