Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: bug in create pin group, replace logger.error with raise Value e… #967

Merged
merged 6 commits into from
Jan 13, 2025
Merged

FIX: bug in create pin group, replace logger.error with raise Value e… #967

merged 6 commits into from
Jan 13, 2025

Conversation

hui-zhou-a
Copy link
Collaborator

…rror

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.68%. Comparing base (fc0c8fa) to head (8207864).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #967   +/-   ##
=======================================
  Coverage   82.68%   82.68%           
=======================================
  Files         160      160           
  Lines       21098    21098           
=======================================
+ Hits        17444    17445    +1     
+ Misses       3654     3653    -1

@github-actions github-actions bot added the grpc-transition Changes that need to be included in gRPC transition label Jan 9, 2025
SMoraisAnsys
SMoraisAnsys previously approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I would raise RuntimeError instead.

Raising ValueError is dedicated to cases where """operation or function receives an argument that has the right type but an inappropriate value""". Here, that's not the case :)

src/pyedb/configuration/cfg_pin_groups.py Outdated Show resolved Hide resolved
src/pyedb/configuration/cfg_pin_groups.py Outdated Show resolved Hide resolved
src/pyedb/dotnet/edb_core/siwave.py Outdated Show resolved Hide resolved
@hui-zhou-a hui-zhou-a merged commit 733701b into main Jan 13, 2025
30 checks passed
@hui-zhou-a hui-zhou-a deleted the fix-edb-cfg-create-pin-group branch January 13, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SMoraisAnsys SMoraisAnsys SMoraisAnsys approved these changes

Assignees
No one assigned
Labels
grpc-transition Changes that need to be included in gRPC transition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hui-zhou-a @codecov-commenter @SMoraisAnsys