-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Updates to use the new self-hosted runner #968
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svandenb-dev
previously approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #968 +/- ##
==========================================
+ Coverage 82.67% 82.70% +0.02%
==========================================
Files 160 160
Lines 21120 21121 +1
==========================================
+ Hits 17462 17468 +6
+ Misses 3658 3653 -5 |
SMoraisAnsys
force-pushed
the
ci/temporary-share-pyaedt-vms
branch
from
January 10, 2025 07:51
2d4078f
to
6dad9eb
Compare
SMoraisAnsys
changed the title
CI: Temporary share PyAEDT VMs
CI: Updates to use the new self-hosted runner
Jan 10, 2025
hui-zhou-a
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci/cd
dependencies
Related with project dependencies
maintenance
Package and maintenance related
testing
Anything related to testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For unknown reason the previous VM stopped working and no fix could be found, a new one was created and it uses standard path for AEDT installation.
I don't know how I succeeded to make all tests to work with the previous VM but, despite all my efforts, I'm no longer able to run test that leverage export_3d_cad aka export_to_hfss, export_to_q3d and export_to_maxwell. The reason is related to Siwave which must be called directly (through /opt/AnsysEM/v242/Linux64/siwave) leading to rendering the UI which is an issue in a non graphical environment.
Note that when using X virtual framebuffer, the tests are just taking too much time...
For the time being I've updated the PR to skip those 3 tests when they are run in linux on CICD. Note that you can still run them if you have a graphic card. For example, I'm able to run the test on export_to_hfss on Linux with my own laptop.