Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Updates to use the new self-hosted runner #968

Merged
merged 16 commits into from
Jan 13, 2025

Conversation

SMoraisAnsys
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys commented Jan 9, 2025

For unknown reason the previous VM stopped working and no fix could be found, a new one was created and it uses standard path for AEDT installation.

I don't know how I succeeded to make all tests to work with the previous VM but, despite all my efforts, I'm no longer able to run test that leverage export_3d_cad aka export_to_hfss, export_to_q3d and export_to_maxwell. The reason is related to Siwave which must be called directly (through /opt/AnsysEM/v242/Linux64/siwave) leading to rendering the UI which is an issue in a non graphical environment.
Note that when using X virtual framebuffer, the tests are just taking too much time...

For the time being I've updated the PR to skip those 3 tests when they are run in linux on CICD. Note that you can still run them if you have a graphic card. For example, I'm able to run the test on export_to_hfss on Linux with my own laptop.

image

@SMoraisAnsys SMoraisAnsys self-assigned this Jan 9, 2025
svandenb-dev
svandenb-dev previously approved these changes Jan 9, 2025
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.70%. Comparing base (0424273) to head (424c8a1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #968      +/-   ##
==========================================
+ Coverage   82.67%   82.70%   +0.02%     
==========================================
  Files         160      160              
  Lines       21120    21121       +1     
==========================================
+ Hits        17462    17468       +6     
+ Misses       3658     3653       -5     

@github-actions github-actions bot added maintenance Package and maintenance related ci/cd labels Jan 9, 2025
@SMoraisAnsys SMoraisAnsys changed the title CI: Temporary share PyAEDT VMs CI: Updates to use the new self-hosted runner Jan 10, 2025
@github-actions github-actions bot added the dependencies Related with project dependencies label Jan 10, 2025
@github-actions github-actions bot added the testing Anything related to testing label Jan 10, 2025
@SMoraisAnsys SMoraisAnsys merged commit 7bef7c3 into main Jan 13, 2025
29 of 30 checks passed
@SMoraisAnsys SMoraisAnsys deleted the ci/temporary-share-pyaedt-vms branch January 13, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd dependencies Related with project dependencies maintenance Package and maintenance related testing Anything related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants