FIX: Arbitrary waveport meshing fix #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/pyedb/dotnet/edb_core/edb_data/hfss_pi_simulation_setup_data.py # src/pyedb/dotnet/edb_core/utilities/simulation_setup.py
# Conflicts: # src/pyedb/dotnet/edb_core/components.py
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #973 +/- ##
==========================================
+ Coverage 82.68% 82.69% +0.01%
==========================================
Files 160 160
Lines 21117 21118 +1
==========================================
+ Hits 17461 17464 +3
+ Misses 3656 3654 -2 |
hui-zhou-a
approved these changes
Jan 14, 2025
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is fixing meshing error on arbitrary waveport used with PyAEDT extension.
The fix consists of scaling the surface create at the void location by 10% to ensure the overlapping and prevent meshing faillure.
closing #975