Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: GetEtchNetClass #978

Merged
merged 1 commit into from
Jan 14, 2025
Merged

FIX: GetEtchNetClass #978

merged 1 commit into from
Jan 14, 2025

Conversation

hui-zhou-a
Copy link
Collaborator

No description provided.

@hui-zhou-a hui-zhou-a linked an issue Jan 14, 2025 that may be closed by this pull request
2 tasks
@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.69%. Comparing base (8b5a502) to head (7a4092a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #978   +/-   ##
=======================================
  Coverage   82.68%   82.69%           
=======================================
  Files         160      160           
  Lines       21118    21121    +3     
=======================================
+ Hits        17462    17465    +3     
  Misses       3656     3656           

Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hui-zhou-a hui-zhou-a merged commit 5ff3b07 into main Jan 14, 2025
30 checks passed
@hui-zhou-a hui-zhou-a deleted the fix-GetEtchNetClass branch January 14, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GetEtchNetClass doesn't exist before 2024.2
3 participants