Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: merge_via bugs #991

Merged
merged 2 commits into from
Jan 22, 2025
Merged

FIX: merge_via bugs #991

merged 2 commits into from
Jan 22, 2025

Conversation

boyang2022
Copy link
Collaborator

@boyang2022 boyang2022 commented Jan 21, 2025

this pull request fixes net_filter and start/stop layer bugs in merge_via

@github-actions github-actions bot added testing Anything related to testing grpc-transition Changes that need to be included in gRPC transition labels Jan 21, 2025
@boyang2022 boyang2022 changed the title Bug merge via Fix merge_via bugs Jan 21, 2025
@boyang2022 boyang2022 changed the title Fix merge_via bugs FIX: merge_via bugs Jan 21, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.68%. Comparing base (e804b3a) to head (5b7bf99).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #991   +/-   ##
=======================================
  Coverage   82.67%   82.68%           
=======================================
  Files         160      160           
  Lines       21130    21132    +2     
=======================================
+ Hits        17470    17473    +3     
+ Misses       3660     3659    -1     

Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svandenb-dev svandenb-dev merged commit aba86f0 into main Jan 22, 2025
30 checks passed
@svandenb-dev svandenb-dev deleted the bug_merge_via branch January 22, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grpc-transition Changes that need to be included in gRPC transition testing Anything related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants