Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the RenderableVNC class to use the <ansys-nexus-viewer> compon… #337

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

david-bremer
Copy link
Collaborator

This PR uses the component instead of using an html page, so that we don't have to test and maintain the VNC pipeline that goes through vnc_envision.html. The 'connect_to_running_ens' option on the component should allow this.

Mike, I looked at the logic in RenderableEVSN to figure out where to add the optional query. But I am not sure how to test this inside AnsysLab.

Mario, maybe the RenderableVNCAngular class can use the component too.

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8cf3805) 80.12% compared to head (c9cb883) 79.92%.

Files Patch % Lines
src/ansys/pyensight/core/renderable.py 85.71% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #337      +/-   ##
==========================================
- Coverage   80.12%   79.92%   -0.21%     
==========================================
  Files          18       18              
  Lines        2561     2570       +9     
  Branches      453      454       +1     
==========================================
+ Hits         2052     2054       +2     
- Misses        353      357       +4     
- Partials      156      159       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariostieriansys
Copy link
Collaborator

@david-bremer well more than using directly the ansys-nexus-viewer component like you are doing there, I should use a similar approach to call the web-en-sight component, that is the angular component.
Right now, like it was done for the VNC renderable, I am building a URL to the HTML contained in ansys/nexus/angular. I could generate one on the fly. The only issue is that I am passing to that URL the information that then I use inside of the angular component to pass to the ansys-nexus-viewer component. I need to find a way to pass these info downstream, since I cannot pass directly attributes to the angular component as of today

@mariostieriansys mariostieriansys merged commit d16685f into main Nov 20, 2023
21 checks passed
@mariostieriansys mariostieriansys deleted the feat/RenderableVNC_use_web_component branch November 20, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants