-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add stochastic fem example #3648
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3648 +/- ##
==========================================
- Coverage 87.14% 87.09% -0.05%
==========================================
Files 187 187
Lines 14697 14697
==========================================
- Hits 12808 12801 -7
- Misses 1889 1896 +7 |
24fc4a8
to
28521e4
Compare
5a1eae2
to
9f27581
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@germa89 can you please provide feedback on the work done so far? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@moe-ad great example! Really. It is very detailed, well documented and well written. The PyMAPDL code is great. I like that you do not recreate the model, rather change the materials. Also I like you used the MapdlPool
object. I wonder if you had much issues with it.
Given the topic (stochastic FEM) I was considering to move it to Academic examples
section but that section is interactive. So let's keep it here for the moment.
Also your CICD failed because |
Thank you very much @germa89 for the detailed review. |
That is the appropriate section for it truly but I couldn't think of a way we could include this example there since sphinx gallery handles that section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@moe-ad This is one of the most complex examples I've seen, and I am very impressed. I've no knowledge of the subject matter, so feel free to ignore suggestions that are inappropriate. Great job!
@PipKat thank you for the detailed reviewed. I have incorporated all of your suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
This PR will add an example to the PyMAPDL documentation
Checklist
draft
if it is not ready to be reviewed yet.feat: adding new MAPDL command
)