Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add stochastic fem example #3648

Merged
merged 32 commits into from
Jan 23, 2025
Merged

feat: add stochastic fem example #3648

merged 32 commits into from
Jan 23, 2025

Conversation

moe-ad
Copy link
Contributor

@moe-ad moe-ad commented Jan 10, 2025

Description

This PR will add an example to the PyMAPDL documentation

Checklist

@moe-ad moe-ad self-assigned this Jan 10, 2025
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added documentation Documentation related (improving, adding, etc) new feature Request or proposal for a new feature labels Jan 10, 2025
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.09%. Comparing base (e6221a6) to head (9eb7d9b).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3648      +/-   ##
==========================================
- Coverage   87.14%   87.09%   -0.05%     
==========================================
  Files         187      187              
  Lines       14697    14697              
==========================================
- Hits        12808    12801       -7     
- Misses       1889     1896       +7     

@moe-ad moe-ad force-pushed the feat/add-stochastic-fem-example branch from 24fc4a8 to 28521e4 Compare January 12, 2025 13:12
@moe-ad moe-ad force-pushed the feat/add-stochastic-fem-example branch from 5a1eae2 to 9f27581 Compare January 14, 2025 10:18
@moe-ad
Copy link
Contributor Author

moe-ad commented Jan 20, 2025

@germa89 can you please provide feedback on the work done so far?
Thank you.

Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moe-ad great example! Really. It is very detailed, well documented and well written. The PyMAPDL code is great. I like that you do not recreate the model, rather change the materials. Also I like you used the MapdlPool object. I wonder if you had much issues with it.

Given the topic (stochastic FEM) I was considering to move it to Academic examples section but that section is interactive. So let's keep it here for the moment.

@germa89
Copy link
Collaborator

germa89 commented Jan 20, 2025

Also your CICD failed because precommit bot did the last commit, so you might want to do an empty commit to retrigger. Also check vale issues.

@moe-ad
Copy link
Contributor Author

moe-ad commented Jan 20, 2025

Thank you very much @germa89 for the detailed review.

@moe-ad
Copy link
Contributor Author

moe-ad commented Jan 20, 2025

Given the topic (stochastic FEM) I was considering to move it to Academic examples section but that section is interactive. So let's keep it here for the moment.

That is the appropriate section for it truly but I couldn't think of a way we could include this example there since sphinx gallery handles that section.

Copy link
Member

@PipKat PipKat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moe-ad This is one of the most complex examples I've seen, and I am very impressed. I've no knowledge of the subject matter, so feel free to ignore suggestions that are inappropriate. Great job!

@moe-ad
Copy link
Contributor Author

moe-ad commented Jan 23, 2025

@PipKat thank you for the detailed reviewed. I have incorporated all of your suggestions.

Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were no major suggestions the time before, and @PipKat already reviewed it. I am assuming no big changes since last I reviewed. So I am happy to approve.

Good job @moe-ad !! Very nice and detailed example!

@github-actions github-actions bot added the CI/CD Related with CICD, Github Actions, etc label Jan 23, 2025
@github-actions github-actions bot removed the CI/CD Related with CICD, Github Actions, etc label Jan 23, 2025
@moe-ad moe-ad merged commit 55903b2 into main Jan 23, 2025
50 checks passed
@moe-ad moe-ad deleted the feat/add-stochastic-fem-example branch January 23, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation related (improving, adding, etc) new feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants