Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Option to ignore lock file on open #1007

Merged
merged 8 commits into from
Jan 2, 2025
Merged

Conversation

klmcadams
Copy link
Collaborator

  • Remove the lock file if it exists before opening the project. By default, remove_lock=False
  • Emit a warning to the user that the project file can be corrupted if remove_lock=True

Closes #327

@klmcadams klmcadams requested a review from a team as a code owner December 18, 2024 20:49
@github-actions github-actions bot added the enhancement New features or code improvements label Dec 18, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 18, 2024
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.80%. Comparing base (218058a) to head (9eb8bcf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1007      +/-   ##
==========================================
+ Coverage   83.76%   83.80%   +0.04%     
==========================================
  Files          35       35              
  Lines        2260     2266       +6     
==========================================
+ Hits         1893     1899       +6     
  Misses        367      367              

@klmcadams klmcadams enabled auto-merge (squash) January 2, 2025 20:19
@klmcadams klmcadams merged commit 1f79347 into main Jan 2, 2025
42 checks passed
@klmcadams klmcadams deleted the feat/ignore-lock-file branch January 2, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to ignore the lock file on open
4 participants