-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add globals
kwarg to app and adjust ideconfig
behavior
#1017
base: main
Are you sure you want to change the base?
Conversation
Need to update examples. one should use the new globals() argument. Another should avoid globals entirely and import the types manually after constructing the app instance |
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (85.71%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1017 +/- ##
==========================================
- Coverage 87.34% 81.25% -6.09%
==========================================
Files 36 42 +6
Lines 2362 2774 +412
==========================================
+ Hits 2063 2254 +191
- Misses 299 520 +221 |
globals
kwarg to App classideconfig