Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add globals kwarg to app and adjust ideconfig behavior #1017

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

klmcadams
Copy link
Collaborator

  • Add globals kwarg to App class
  • Import globals if the app is initialized

ideconfig

  • Raise an exception if the revision number is less than the minimum version in ansys-mechanical-stubs
  • Raise a warning if the revision number is greater than the maximum version in ansys-mechanical-stubs. Use the max version to print the autocomplete settings

@klmcadams klmcadams requested a review from a team as a code owner January 3, 2025 18:45
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 3, 2025
@koubaa
Copy link
Collaborator

koubaa commented Jan 3, 2025

Need to update examples. one should use the new globals() argument. Another should avoid globals entirely and import the types manually after constructing the app instance

@klmcadams klmcadams marked this pull request as draft January 3, 2025 19:31
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 8 lines in your changes missing coverage. Please review.

Project coverage is 81.25%. Comparing base (bbbd6c3) to head (be93db8).
Report is 2 commits behind head on main.

❌ Your patch check has failed because the patch coverage (85.71%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1017      +/-   ##
==========================================
- Coverage   87.34%   81.25%   -6.09%     
==========================================
  Files          36       42       +6     
  Lines        2362     2774     +412     
==========================================
+ Hits         2063     2254     +191     
- Misses        299      520     +221     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants