Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Process return code #1029

Merged
merged 7 commits into from
Jan 7, 2025
Merged

fix: Process return code #1029

merged 7 commits into from
Jan 7, 2025

Conversation

koubaa
Copy link
Collaborator

@koubaa koubaa commented Jan 7, 2025

There is no crash on shutdown for 251+, but there was still some tests that allowed subprocesses without exceptions to throw a nonzero result. I modified this to only be the case for <251.

Here's the pipeline run for 251: https://github.com/ansys/pymechanical/actions/runs/12652827509

@koubaa koubaa requested a review from a team as a code owner January 7, 2025 13:14
@koubaa koubaa changed the title Process return code fix: Process return code Jan 7, 2025
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 7, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.46%. Comparing base (009b819) to head (817a656).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1029      +/-   ##
==========================================
+ Coverage   86.71%   87.46%   +0.75%     
==========================================
  Files          35       35              
  Lines        2266     2266              
==========================================
+ Hits         1965     1982      +17     
+ Misses        301      284      -17     

@koubaa koubaa merged commit 924d476 into main Jan 7, 2025
83 of 84 checks passed
@koubaa koubaa deleted the process-return-code branch January 7, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants