Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHORE: Support python 3.13 #997

Merged
merged 3 commits into from
Jan 8, 2025
Merged

CHORE: Support python 3.13 #997

merged 3 commits into from
Jan 8, 2025

Conversation

dipinknair
Copy link
Collaborator

  • Support 3.13
  • Update main python for ci/cd

@github-actions github-actions bot added documentation Improvements or additions to documentation maintenance Package and maintenance related dependencies Related with project dependencies ci/cd Involves the GitHub workflow files enhancement New features or code improvements labels Dec 9, 2024
@dipinknair
Copy link
Collaborator Author

@RobPasMue, @ansys/pymechanical-maintainers . Will keep this as draft till pythonnet start supporting 3.13

@dipinknair dipinknair self-assigned this Dec 9, 2024
@RobPasMue
Copy link
Member

RobPasMue commented Dec 10, 2024 •
edited
Loading

We should reach out to them.. see pythonnet/pythonnet#2454 (comment)

@codecov Codecov
Copy link

codecov bot commented Jan 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.73%. Comparing base (b81bef2) to head (98a50cc).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #997      +/-   ##
==========================================
- Coverage   83.82%   83.73%   -0.09%     
==========================================
  Files          35       35              
  Lines        2269     2269              
==========================================
- Hits         1902     1900       -2     
- Misses        367      369       +2

@dipinknair dipinknair marked this pull request as ready for review January 8, 2025 15:26
@dipinknair dipinknair requested a review from a team as a code owner January 8, 2025 15:26
@dipinknair dipinknair requested a review from RobPasMue January 8, 2025 15:26
RobPasMue
RobPasMue approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RobPasMue RobPasMue linked an issue Jan 8, 2025 that may be closed by this pull request
[MAINTENANCE] Support for Python 3.13 #995
Closed
@dipinknair dipinknair merged commit 9ab4288 into main Jan 8, 2025
58 checks passed
@dipinknair dipinknair deleted the feat/py313 branch January 8, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

Assignees

@dipinknair dipinknair

Labels
ci/cd Involves the GitHub workflow files dependencies Related with project dependencies documentation Improvements or additions to documentation enhancement New features or code improvements maintenance Package and maintenance related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MAINTENANCE] Support for Python 3.13
3 participants
@dipinknair @RobPasMue @pyansys-ci-bot