Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New API update_semiconductor_wearout_props() #488

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ansnfernand
Copy link
Collaborator

@ansnfernand ansnfernand commented Jan 20, 2025

Description

New API update_semiconductor_wearout_props()

Issue linked

#484

Checklist:

  • Run unit tests and make sure they all pass
    - Run tests without Sherlock running
    - Run tests with Sherlock GRPC connection
  • Check and fix style errors
    - pre-commit command line check
    - Problems tab in PyCharm
  • Bench test new/modified APIs by using and modifying the code in the example for the API method
  • [] Add new classes to rst files, located at: \doc\source\api
  • Generate documentation
  • Verify the HTML. It gets generated at: \doc\build\html.
    - Open index.html
    - Click on "API Reference" at the top.
    - Verify HTML for API changes.
  • Check that test code coverage is at least 80% when Sherlock is running
  • Make sure that the title of the pull request follows Commit naming conventions (e.g. feat: adding new PySherlock command)

@ansnfernand ansnfernand added the enhancement New features or code improvements label Jan 20, 2025
@ansnfernand ansnfernand added this to the v0.9.0 milestone Jan 20, 2025
@ansnfernand ansnfernand requested a review from ansjmoody January 20, 2025 10:54
@ansnfernand ansnfernand self-assigned this Jan 20, 2025
@ansnfernand ansnfernand linked an issue Jan 20, 2025 that may be closed by this pull request
@github-actions github-actions bot added the testing Anything related to tests label Jan 20, 2025
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New features or code improvements testing Anything related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new API: update_semiconductor_wearout_props()
2 participants