Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New API update_semiconductor_wearout_props() #488

Merged
merged 4 commits into from
Jan 22, 2025

Conversation

ansnfernand
Copy link
Collaborator

@ansnfernand ansnfernand commented Jan 20, 2025

Description

New API update_semiconductor_wearout_props()

Issue linked

#484

Checklist:

  • Run unit tests and make sure they all pass
    - Run tests without Sherlock running
    - Run tests with Sherlock GRPC connection
  • Check and fix style errors
    - pre-commit command line check
    - Problems tab in PyCharm
  • Bench test new/modified APIs by using and modifying the code in the example for the API method
  • [] Add new classes to rst files, located at: \doc\source\api
  • Generate documentation
  • Verify the HTML. It gets generated at: \doc\build\html.
    - Open index.html
    - Click on "API Reference" at the top.
    - Verify HTML for API changes.
  • Check that test code coverage is at least 80% when Sherlock is running
  • Make sure that the title of the pull request follows Commit naming conventions (e.g. feat: adding new PySherlock command)

@ansnfernand ansnfernand added the enhancement New features or code improvements label Jan 20, 2025
@ansnfernand ansnfernand added this to the v0.9.0 milestone Jan 20, 2025
@ansnfernand ansnfernand requested a review from ansjmoody January 20, 2025 10:54
@ansnfernand ansnfernand self-assigned this Jan 20, 2025
@ansnfernand ansnfernand linked an issue Jan 20, 2025 that may be closed by this pull request
@github-actions github-actions bot added testing Anything related to tests documentation Improvements or additions to documentation labels Jan 20, 2025
src/ansys/sherlock/core/analysis.py Show resolved Hide resolved
tests/test_analysis.py Show resolved Hide resolved
@ansnfernand ansnfernand force-pushed the nayane/update_semiconductor_wearout_props() branch from 33932a0 to fc2af43 Compare January 22, 2025 10:05
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 56.60377% with 23 lines in your changes missing coverage. Please review.

Project coverage is 60.03%. Comparing base (5e997ed) to head (fc2af43).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/sherlock/core/types/analysis_types.py 60.86% 18 Missing ⚠️
src/ansys/sherlock/core/analysis.py 28.57% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #488      +/-   ##
==========================================
- Coverage   60.07%   60.03%   -0.04%     
==========================================
  Files          21       21              
  Lines        5009     5062      +53     
==========================================
+ Hits         3009     3039      +30     
- Misses       2000     2023      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ansnfernand ansnfernand requested a review from ansjmoody January 22, 2025 16:00
@ansnfernand ansnfernand merged commit 3ac7086 into main Jan 22, 2025
30 of 32 checks passed
@ansnfernand ansnfernand deleted the nayane/update_semiconductor_wearout_props() branch January 22, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New features or code improvements testing Anything related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new API: update_semiconductor_wearout_props()
3 participants