Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

break event collector loop #702

Merged
merged 13 commits into from
Nov 14, 2023
Merged

break event collector loop #702

merged 13 commits into from
Nov 14, 2023

Conversation

kinrezC
Copy link
Contributor

@kinrezC kinrezC commented Nov 13, 2023

  • Adds missing breaks to break out of the event collector while loop when data is successfully written to file
  • Adds logic for broadcasting a shutdown signal from data_collection.rs threads to the main environment thread to guarantee that output data is written to completion

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b08cb26) 61.20% compared to head (ef82f96) 61.29%.
Report is 4 commits behind head on main.

Files Patch % Lines
bin/bind/digest.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #702      +/-   ##
==========================================
+ Coverage   61.20%   61.29%   +0.09%     
==========================================
  Files          28       28              
  Lines        5735     5749      +14     
==========================================
+ Hits         3510     3524      +14     
  Misses       2225     2225              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kinrezC kinrezC requested review from 0xJepsen, Autoparallel and Alexangelj and removed request for 0xJepsen and Autoparallel November 13, 2023 20:46
@kinrezC kinrezC marked this pull request as ready for review November 13, 2023 20:48
Copy link
Collaborator

@0xJepsen 0xJepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good kush

@0xJepsen 0xJepsen merged commit 437d21a into main Nov 14, 2023
11 checks passed
@0xJepsen 0xJepsen deleted the fix/break-data-collector-loop branch November 14, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants