enhance(arbiter-engine): remove <E, A>
generics from World
#748
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give an overview of the tasks completed
We wanted to not have the
World
struct have generics that come from theEngine<E,A>
inside of theAgent
struct. This PR fixes this by introducing a object-safe traitEntity
that solely provides the interface to doAgent::run()
. Minimal change with no breaks to tests. Changed the agent collection inWorld
fromVec<Agent>
toHashMap<String, Agent>
while I was at it.Link to issue(s) that this PR closes
Closes #747