Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(arbiter-core): stream with meta #863

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Conversation

Autoparallel
Copy link
Collaborator

Give an overview of the tasks completed
Now we can call my_contract.events().stream_with_meta(). Not all fields are populated correctly, and this can be addressed in #824 if we want.

Link to issue(s) that this PR closes
Closes #501

@Autoparallel Autoparallel requested a review from 0xJepsen February 8, 2024 19:34
0xJepsen
0xJepsen previously approved these changes Feb 8, 2024
Copy link
Collaborator

@0xJepsen 0xJepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, i does seem to break one test. It looks like it should be easy to propagate the change to the test. Let me know if you want me to take care of it.

@0xJepsen 0xJepsen merged commit cdb4659 into main Feb 8, 2024
8 checks passed
@0xJepsen 0xJepsen deleted the feat/stream-with-meta branch February 8, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: cannot stream_with_meta() on Events
2 participants