Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing responsive CSS columns #5

Merged
merged 5 commits into from
May 28, 2024
Merged

Missing responsive CSS columns #5

merged 5 commits into from
May 28, 2024

Conversation

fonnets
Copy link
Contributor

@fonnets fonnets commented May 27, 2024

Following the opening of issues # 4 I managed to fix the reported problems. Please accept my changes. Thank you

@DemigodCode
Copy link
Member

Thanks for this PR!

Glad that this package is being used.

@DemigodCode
Copy link
Member

Hey,

seems that some of the tests failed cause of the "\n" fix. Can you please take a look into it?

@fonnets
Copy link
Contributor Author

fonnets commented May 27, 2024

Hi, it looks like the test was failing even before my changes.

@DemigodCode
Copy link
Member

What makes you thinking that?
There are no old GitHub Actions in history because github saves them a few months and then deletes them.
All Tests I see, are failing cause of the fixed "\n".

@fonnets
Copy link
Contributor Author

fonnets commented May 27, 2024

In the development environment I reverted my changes and the tests continue to fail.
It seems that after an old change the test outputs were not updated.

@DemigodCode
Copy link
Member

I've now enabled the manual run and that started the github action anyway.

The master branch is passing.
https://github.com/antibodies-online/bootstrap-email/actions/runs/9256176579

DemigodCode and others added 2 commits May 28, 2024 09:15
@DemigodCode DemigodCode merged commit f47b3a7 into antibodies-online:master May 28, 2024
9 checks passed
@DemigodCode
Copy link
Member

Thanks for your contribution! I've fixed the failing unit tests.

@fonnets
Copy link
Contributor Author

fonnets commented May 28, 2024

Thank you for accepting the changes!

To get the latest version I had to force composer this way
composer require antibodies-online/bootstrap-email dev-master#f47b3a7, is this normal?

Grazie!

@DemigodCode
Copy link
Member

Haven't yet released a new version. Will do that during the day.

@DemigodCode
Copy link
Member

v1.0.4 now available in composer

@fonnets
Copy link
Contributor Author

fonnets commented May 28, 2024

PERFECT 👏👏👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants