Add detection support of TCL versions 8.6 and 8.5 #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to adding labels "8.6" and "8.5" to the list of possible TCL versions, the patch also changes how
libtcl.so
if found. In my system (Ubuntu 18.04)libtcl8.6.so
lives at/usr/lib/x86_64-linux-gnu/
. Trying to figure out why is that I learned Debian and Ubuntu are moving now to a new multiarch implementation where mixed-architecture installations can be managed much more sanely [1], thus this new directory layout.Basically the change does a recursive file search over two root directories and removes the dirname, leaving only the basename of the path. The rest is the same as before.
Regarding version 8.5, I added the label but I couldn't test it (since my system features 8.6).
[1] https://unix.stackexchange.com/questions/43190/where-did-usr-lib64-go-and-what-is-usr-lib-x86-64-linux-gnu