Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detection support of TCL versions 8.6 and 8.5 #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dpino
Copy link

@dpino dpino commented Oct 14, 2018

In addition to adding labels "8.6" and "8.5" to the list of possible TCL versions, the patch also changes how libtcl.soif found. In my system (Ubuntu 18.04) libtcl8.6.so lives at /usr/lib/x86_64-linux-gnu/. Trying to figure out why is that I learned Debian and Ubuntu are moving now to a new multiarch implementation where mixed-architecture installations can be managed much more sanely [1], thus this new directory layout.

Basically the change does a recursive file search over two root directories and removes the dirname, leaving only the basename of the path. The rest is the same as before.

Regarding version 8.5, I added the label but I couldn't test it (since my system features 8.6).

[1] https://unix.stackexchange.com/questions/43190/where-did-usr-lib64-go-and-what-is-usr-lib-x86-64-linux-gnu

@dpino
Copy link
Author

dpino commented Oct 14, 2018

I just noticed #13. I tested it and it doesn't work in my system, because of the new directory layout. I'm fine closing this PR, but #13 would need to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant