[JavaScript] Fix incorrect this.channel access #4570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nextTokenOnChannel was accessing the field `this.channel` instead of the parameter `channel`. The buffered token stream class doesn't have a field named `channel`, so this exhausted the token buffer instead. The bug had not been caught because it is only called from `CommonTokenStream` with parameter `this.channel`. Signed-off-by: Phlosioneer <[email protected]>
|
Pfff!! How did this one survive 10 years ? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BufferedTokenStream::nextTokenOnChannelwas accessing the fieldthis.channelinstead of the parameterchannel. The buffered token stream class doesn't have a field namedchannel, so this exhausted the token buffer instead.The bug had not been caught because it is only called from
CommonTokenStreamwith parameterthis.channel.