Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating documentations for ANTLR 5 #23

Merged
merged 4 commits into from
Feb 5, 2024
Merged

Updating documentations for ANTLR 5 #23

merged 4 commits into from
Feb 5, 2024

Conversation

ftomassetti
Copy link
Collaborator

@ftomassetti ftomassetti commented Feb 3, 2024 •
edited
Loading

This PR does a combination of minor things to update references to ANTLR4 into references to ANTLR5.

  • It updates information on contributing, specifying that from the beginning ANTLR 5 is using the DCO mechanism and removing the historical contribution agreement
  • remove the changelog file, not been updated since 2014
  • remove several files documenting dropped targets
  • update the document on releasing ANTLR very coarsely, by removing paragraphs about dropped targets and changing the references to ANTLR 4 into references to ANTLR 5

Moved to the #26 instead:

  • It renames Antlr4MojoTest into Antlr5MojoTest
  • from POM, remove the configuration for cleaning the swift target, as it has been dropped

@ftomassetti ftomassetti force-pushed the chore/moreUpdatesToAntlr5 branch from e4dcc48 to 07b6582 Compare February 3, 2024 13:15
@ftomassetti ftomassetti marked this pull request as ready for review February 3, 2024 13:47
ericvergnaud
ericvergnaud requested changes Feb 3, 2024
View reviewed changes
Copy link
Contributor

@ericvergnaud ericvergnaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have separate PRs for code changes and doc changes ?

@ftomassetti ftomassetti mentioned this pull request Feb 5, 2024
Merged
@ftomassetti
Copy link
Collaborator Author

ftomassetti commented Feb 5, 2024 •
edited
Loading

Can we have separate PRs for code changes and doc changes ?

Sure, I extracted #26 to focus on code and infrastructure, and I have updated this PR to focus exclusively on documentation

@ftomassetti ftomassetti force-pushed the chore/moreUpdatesToAntlr5 branch from 07b6582 to 8ce8665 Compare February 5, 2024 15:08
@ftomassetti ftomassetti changed the title More updates to antlr5 Updating documentations for ANTLR 5 Feb 5, 2024
@ftomassetti
Copy link
Collaborator Author

In this case, after I performed the changes requested, should I press the button Re-request review or is it enough to add a comment in the PR?

@ericvergnaud
Copy link
Contributor

In this case, after I performed the changes requested, should I press the button Re-request review or is it enough to add a comment in the PR?

I guess the former expresses clearly that from your POV it is ready ?

@ericvergnaud
Copy link
Contributor

Plus technically I think it triggers a review workflow, which maybe helps close the previous review. Let's find out ?

@ftomassetti
Copy link
Collaborator Author

Thanks, I pressed the button

@ericvergnaud ericvergnaud merged commit d7646a9 into antlr:dev Feb 5, 2024
10 checks passed
@ericvergnaud
Copy link
Contributor

ericvergnaud commented Feb 5, 2024 •
edited
Loading

It does help close the previous review 😄

@ftomassetti ftomassetti deleted the chore/moreUpdatesToAntlr5 branch February 5, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericvergnaud ericvergnaud ericvergnaud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ftomassetti @ericvergnaud