Refactor code of left-recursive rules processing and get rid of LeftRecursiveRuleWalker.g
#38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Kochurkin <[email protected]>
…ker.g` dependency Use handwritten DFS for analyzing rule alternatives. Improve performance. Signed-off-by: Ivan Kochurkin <[email protected]>
…e, improve performance Signed-off-by: Ivan Kochurkin <[email protected]>
|
@parrt adding you as a reviewer since you may have concerns that we're not aware of. It'd be useful to understand why you chose to rely on antlr rather than hand code processing of left-recursive rules ? |
We had that tree pattern matcher back in the day so it was easier just to use that then hand code a subtree matcher. at least that's what I remember. |
ericvergnaud
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It simplifies code of processing left-recursive rules and it removes
LeftRecursiveRuleWalker.gthat will help you to get rid of ANTLR 3 dependency in the future.