Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PUT Project] Add format support for Raviewer formats and MJPEG #1

Merged
merged 9 commits into from
Jan 22, 2024

Conversation

jbylicki
Copy link
Collaborator

This PR implements support for various pixel format types listed in raviewer. Additionally, apart from YUY2, cameras typically support MJPEG and as listed this format was also added

@jbylicki jbylicki requested a review from glatosinski January 15, 2024 16:34
@glatosinski
Copy link

ci_runner: pixelformatsinfo: Added enumeration of supported formats for CI - this commit requires splitting into at least two commits - one with update to formats' conversions, second one with the CI binary creation.

@glatosinski
Copy link

README.md: cameracapture.cpp: Added chroma subsampling buffer rescaling - the commit message refers to README changes, but contains changes in cpp file, let's split it into two commits

@glatosinski
Copy link

I'd suggest having one commit for all README changes, and separate commits for changes in the actual code.

Copy link

@glatosinski glatosinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I finished the first round of review - please find requested changes in the comments.

@jbylicki jbylicki force-pushed the add-format-support branch 3 times, most recently from 10936ef to d47177e Compare January 18, 2024 17:45
@jbylicki jbylicki requested a review from glatosinski January 18, 2024 17:46
Copy link

@glatosinski glatosinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes requested, let's apply fixes and merge this PR.

@glatosinski
Copy link

Please rebase the branch on top of main (contains fix for the linting job).

@jbylicki jbylicki force-pushed the add-format-support branch 9 times, most recently from 3c08cc5 to cba76d7 Compare January 22, 2024 14:29
jbylicki and others added 9 commits January 22, 2024 15:33
Co-authored-by: DiegoBalagane <[email protected]>
Co-authored-by: Reinie78 <[email protected]>
Co-authored-by: DiegoBalagane <[email protected]>
Co-authored-by: Reinie78 <[email protected]>
Co-authored-by: DiegoBalagane <[email protected]>
Co-authored-by: Reinie78 <[email protected]>

Signed-off-by: Jan Bylicki <[email protected]>
Copy link

@glatosinski glatosinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glatosinski glatosinski merged commit 7b7aca4 into main Jan 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants