-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PUT Project] Add format support for Raviewer formats and MJPEG #1
Conversation
|
|
I'd suggest having one commit for all README changes, and separate commits for changes in the actual code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I finished the first round of review - please find requested changes in the comments.
include/grabthecam/frameconverters/packedformats2rgbconverter.hpp
Outdated
Show resolved
Hide resolved
10936ef
to
d47177e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes requested, let's apply fixes and merge this PR.
Please rebase the branch on top of |
3c08cc5
to
cba76d7
Compare
Co-authored-by: DiegoBalagane <[email protected]> Co-authored-by: Reinie78 <[email protected]>
Co-authored-by: DiegoBalagane <[email protected]> Co-authored-by: Reinie78 <[email protected]>
Co-authored-by: DiegoBalagane <[email protected]> Co-authored-by: Reinie78 <[email protected]>
Co-authored-by: DiegoBalagane <[email protected]> Co-authored-by: Reinie78 <[email protected]>
Co-authored-by: DiegoBalagane <[email protected]> Co-authored-by: Reinie78 <[email protected]>
Co-authored-by: DiegoBalagane <[email protected]> Co-authored-by: Reinie78 <[email protected]>
Co-authored-by: DiegoBalagane <[email protected]> Co-authored-by: Reinie78 <[email protected]>
Co-authored-by: DiegoBalagane <[email protected]> Co-authored-by: Reinie78 <[email protected]> Signed-off-by: Jan Bylicki <[email protected]>
cba76d7
to
2706198
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR implements support for various pixel format types listed in raviewer. Additionally, apart from YUY2, cameras typically support MJPEG and as listed this format was also added