Recorder xml #2
Recorder xml #2
Conversation
There was a problem hiding this comment.
@gilserrancoli, I had a first look. I wonder whether it is necessary to uncomment everything. In the end we do not support certain things with AD, such as the elastic foundation model. So I am not sure we should make that available.
| target_link_libraries(${TEST_TARGET} osimSimulation) | ||
| set_target_properties(${TEST_TARGET} PROPERTIES | ||
| FOLDER "External_Functions") | ||
| OpenSimCopySharedTestFiles(Pendulum2dof.osim) |
There was a problem hiding this comment.
Can you add an empty line in the end?
| @@ -0,0 +1,147 @@ | |||
| /* This code describes the OpenSim model and the skeleton dynamics | |||
There was a problem hiding this comment.
Can you adjust the tabs to make it look nice? Thanks.
| // | ||
| //} // end of namespace OpenSim | ||
| /* -------------------------------------------------------------------------- * | ||
| * OpenSim: ElasticFoundationForce.cpp * |
There was a problem hiding this comment.
Do we support that with AD? I don't think so...I don't think we should uncomment if we do not support...
| @@ -25,6 +25,7 @@ | |||
| // INCLUDES | |||
| //============================================================================= | |||
| #include "Body.h" | |||
| #include <OpenSim/Common/XMLDocument.h> | |||
There was a problem hiding this comment.
Strange that we need to add those
| @@ -30,7 +30,7 @@ | |||
| #include <OpenSim/Common/Constant.h> | |||
| #include <OpenSim/Common/LinearFunction.h> | |||
| #include "simbody/internal/MobilizedBody_FunctionBased.h" | |||
|
|
|||
| #include <OpenSim/Common/XMLDocument.h> | |||
| @@ -19,5 +19,6 @@ if(BUILD_TESTING) | |||
| add_subdirectory(ExampleLuxoMuscle) | |||
| add_subdirectory(AnalysisPluginExample) | |||
| add_subdirectory(BodyDragExample) | |||
| add_subdirectory(testReadOsimFile) | |||
There was a problem hiding this comment.
I would include Recorder or AD as part of the test name
| @@ -0,0 +1,1045 @@ | |||
| <?xml version="1.0" encoding="UTF-8" ?> | |||
There was a problem hiding this comment.
Where does this model come from?
| @@ -0,0 +1,53 @@ | |||
|
|
|||
There was a problem hiding this comment.
Can you clean this? There are some unnecessary comments.
| @@ -0,0 +1,100 @@ | |||
| /* -------------------------------------------------------------------------- * | |||
There was a problem hiding this comment.
Let's work on the test in the end. I think we should test more features.
| ARCHIVE DESTINATION lib | ||
| RUNTIME DESTINATION bin | ||
| ) | ||
|
|
There was a problem hiding this comment.
Seems to be an empty line in the end
Use ezc3d's exported target.
… from Movement Simulation subject
Avoid issue with order of tibial faces (columns in pairs) and change pressure calculation
Still need to work on it
…l function of Movement Simulation Subject
RatHidLimb version data May
Those are the changes to enable the reading of .osim files in the AD version of OpenSim. The main changes consist of enabling readFromXML... functions.
I added a test to read arm26_noMuscles .osim and gait2354_simbody osim file with no muscles and no Yamaguchi knee functions (gait2354_simbody_noMuscles_nokneeYamag.osim).
Pendulum_2dof_osim External function has also been created to read the model directly from the .osim file and prepared to run an OCP.