Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use response.arrayBuffer instead of response.buffer #443

Merged
merged 2 commits into from
Feb 6, 2024
Merged

use response.arrayBuffer instead of response.buffer #443

merged 2 commits into from
Feb 6, 2024

Conversation

newhouse
Copy link
Contributor

@newhouse newhouse commented Feb 5, 2024 •
edited
Loading

Description of the change

Stop an annoying deprecation warning by using the response.arrayBuffer rather than the response.buffer for buffer-like binary responses

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fixes #442

Checklists

Development

  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development
  • No previous tests unrelated to the changed code fail in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached.
  • At least one reviewer has been requested
  • Changes have been reviewed by at least one other engineer
  • The relevant project board has been selected in Projects to auto-link to this pull request

@newhouse newhouse force-pushed the newhouse/442/arrayBuffer-instead-of-buffer branch from e2bc6e6 to 5ffb99b Compare February 6, 2024 00:02
@newhouse newhouse mentioned this pull request Feb 6, 2024
Closed
10 tasks
@newhouse
Copy link
Contributor Author

newhouse commented Feb 6, 2024

@wi-ski

@newhouse newhouse merged commit 0922f92 into main Feb 6, 2024
8 checks passed
@newhouse newhouse deleted the newhouse/442/arrayBuffer-instead-of-buffer branch February 6, 2024 00:18
@newhouse
Copy link
Contributor Author

newhouse commented Feb 6, 2024

Released in v 3.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benogle benogle benogle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@newhouse @benogle