-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task: Create an "About Us" page and add build number info #53
Conversation
Adding file (3)
@@ -0,0 +1,27 @@ | |||
// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should not push generated code
static String build = ""; | ||
static Future init() async { | ||
PackageInfo packageInfo = await PackageInfo.fromPlatform(); | ||
print(packageInfo.version); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove debug print
var lightTheme = ThemeData( | ||
primaryColorDark: Color(0xFF707070), | ||
primaryColorLight: Color(0xFF404040), | ||
inputDecorationTheme: const InputDecorationTheme( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should not remove existing styles
), | ||
brightness: Brightness.light, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not quite sure this is needed since we have colorScheme
@@ -88,6 +89,11 @@ class AnyFluroRouter { | |||
'settings/addresses', | |||
handler: newHandler(() => Addresses(), []), | |||
transitionType: TransitionType.inFromBottom, | |||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use same identation
], | ||
), | ||
onTap: () { | ||
Navigator.pushNamed(context, '/settings/about_us'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use path without slash at the start
_SelectCurrencyLink(context), | ||
_BusinessInfoLink(context), | ||
_AddressesLink(context), | ||
_buildAboutUs(context), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_AboutUsLink ?
### Things done