Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved config generation method; added saving of current account an… #80

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mighty-sponge
Copy link
Contributor

…d network identifiers


  • I understand that contributing to this repository will require me to agree with the CLA

Description

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 tech-docs
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

Copy link

socket-security bot commented Jul 2, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
pypi/[email protected] None +2 1.31 MB bbc, theskumar

View full report↗︎

Makefile Outdated
--volume ${CURDIR}/:/code/ \
generateconfig-env
docker run --rm --volume ${CURDIR}/:/code/ --detach generateconfig-env
sleep 2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need sleep here?

@mighty-sponge mighty-sponge requested a review from fb929 November 12, 2024 15:33
@afro-systems
Copy link

Is this getting merged?

@mighty-sponge
Copy link
Contributor Author

Is this getting merged?

this will be merged as soon as approval is received and migration tests are passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants