Skip to content

Commit

Permalink
test: failing tests invalid image
Browse files Browse the repository at this point in the history
Signed-off-by: Mateusz Urbanek <[email protected]>
  • Loading branch information
shanduur committed Jan 31, 2025
1 parent 323fe94 commit 7fb169c
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 10 deletions.
14 changes: 7 additions & 7 deletions api/v1alpha1/image_conversion_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ func TestConvertFromTo(t *testing.T) {
},
Spec: imagebuilderv1alpha2.ImageSpec{
Builder: imagebuilderv1alpha2.Container{
Image: "ghcr.io/anza-labs/image-builder:v0.1.0",
Image: "ghcr.io/anza-labs/image-builder-linuxkit:v0.1.0",
Verbosity: 4,
Resources: corev1.ResourceRequirements{
Limits: corev1.ResourceList{
Expand Down Expand Up @@ -89,7 +89,7 @@ func TestConvertFromTo(t *testing.T) {
Namespace: "test",
},
Spec: ImageSpec{
BuilderImage: "ghcr.io/anza-labs/image-builder:v0.1.0",
BuilderImage: "ghcr.io/anza-labs/image-builder-linuxkit:v0.1.0",
BuilderVerbosity: 4,
Resources: corev1.ResourceRequirements{
Limits: corev1.ResourceList{
Expand Down Expand Up @@ -144,22 +144,22 @@ func TestImageFrom(t *testing.T) {
expectedOut: "",
},
"valid image": {
v1alpha1Image: "image-builder:latest",
v1alpha1Image: "image-builder-linuxkit:latest",
targetImage: "image-builder-init-objfetcher",
expectedOut: "docker.io/library/image-builder-init-objfetcher:latest",
},
"valid image with tag": {
v1alpha1Image: "ghcr.io/anza-labs/image-builder:latest",
v1alpha1Image: "ghcr.io/anza-labs/image-builder-linuxkit:latest",
targetImage: "image-builder-init-objfetcher",
expectedOut: "ghcr.io/anza-labs/image-builder-init-objfetcher:latest",
},
"valid image without registry": {
v1alpha1Image: "anza-labs/image-builder:latest",
v1alpha1Image: "anza-labs/image-builder-linuxkit:latest",
targetImage: "image-builder-init-objfetcher",
expectedOut: "docker.io/anza-labs/image-builder-init-objfetcher:latest",
},
"valid image without local registry": {
v1alpha1Image: "localhost:5005/anza-labs/image-builder:latest",
v1alpha1Image: "localhost:5005/anza-labs/image-builder-linuxkit:latest",
targetImage: "image-builder-init-objfetcher",
expectedOut: "localhost:5005/anza-labs/image-builder-init-objfetcher:latest",
},
Expand All @@ -169,7 +169,7 @@ func TestImageFrom(t *testing.T) {
expectedOut: "ghcr.io/anza-labs/image-builder-init-objfetcher@sha256:008b026f11c0b5653d564d0c9877a116770f06dfbdb36ca75c46fd593d863cbc",
},
"valid image with tag and digest": {
v1alpha1Image: "ghcr.io/anza-labs/image-builder:v0.1.2@sha256:008b026f11c0b5653d564d0c9877a116770f06dfbdb36ca75c46fd593d863cbc",
v1alpha1Image: "ghcr.io/anza-labs/image-builder-linuxkit:v0.1.2@sha256:008b026f11c0b5653d564d0c9877a116770f06dfbdb36ca75c46fd593d863cbc",
targetImage: "image-builder-init-objfetcher",
expectedOut: "ghcr.io/anza-labs/image-builder-init-objfetcher:v0.1.2@sha256:008b026f11c0b5653d564d0c9877a116770f06dfbdb36ca75c46fd593d863cbc",
},
Expand Down
3 changes: 0 additions & 3 deletions config/rbac/role.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,6 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
name: manager-role
labels:
app.kubernetes.io/name: image-builder
app.kubernetes.io/managed-by: kustomize
rules:
- apiGroups:
- ""
Expand Down

0 comments on commit 7fb169c

Please sign in to comment.