Hotfix/with martin cudatrackjob #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 19, 2019 12:14
…CBuffer containers
…b with an externally held output buffer
- provides specializations of the prepare output structures (i.e. beam monitors and elem-by-elem configuration
) methods which attempt to send the changed beam elements buffer and the updated elem-by-elem config
via the arguments rather than keeping the changes only local.
- this fixes an issue encountered with the python CudaTrackJob where the output buffer was always
stored externally to allow easier sharing with python. It seems that under this circumstances,
the lattices were not always resend after reset, thus this change was added.
NOTE: There is a chance that with this change, the beam-elements buffer and the elem-by-elem
config are transfered twice. This is not ideal and should be ensured to not occur which
will be done in the context of the major restructuring of the TrackJob infrastructure
…th externally owned output buffers
|
Unfortunately this does not yet seem to solve the issue with the empty results after (see cell 23) |
aoeftiger
pushed a commit
that referenced
this pull request
Aug 16, 2019
Space charge implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could you please check whether these changes fix the problem with the output buffer?
Please let me know either way :-)
Cheers,
Martin