add volume modification by mouse scrolling #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Prisacaru Bogdan-Paul <[email protected]>
|
@VladWero08 sorry for the late reply. Can you merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #446
In this PR we have added two more mouse event listeners, for scroll up and for scroll down of the mouse's wheel. This event listeners should only work if the keymap.toml has the following two entries:
where m s u stands for MouseScrollUp and m s d for MouseScrollDown.
Instead of mixing the key_sequence configuration with the mouse movements, we think that it would be useful to have a separate configuration for mouse events.