Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build with sixel feature on windows #638

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
use experimental icy_sixel
juliamertz committed Dec 16, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit c02087eb4b259baa709fc795572ef293cba5f301
10 changes: 8 additions & 2 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion spotify_player/Cargo.toml
Original file line number Diff line number Diff line change
@@ -41,7 +41,7 @@ tracing = "0.1.41"
tracing-subscriber = { version = "0.3.19", features = ["env-filter"] }
backtrace = "0.3.74"
souvlaki = { version = "0.7.3", optional = true }
viuer = { version = "0.9.1", optional = true }
viuer = { version = "0.9.1", git = "https://github.com/ollbx/viuer/", branch = "icy_sixel", features = ["icy_sixel"], optional = true }
image = { version = "0.25.5", optional = true }
notify-rust = { version = "4.11.3", optional = true, default-features = false, features = [
"d",
12 changes: 7 additions & 5 deletions spotify_player/src/ui/playback.rs
Original file line number Diff line number Diff line change
@@ -375,7 +375,7 @@ fn render_playback_cover_image(state: &SharedState, ui: &mut UIStateGuard) -> Re
let width = (f32::from(rect.width) * scale).round() as u32;
let height = (f32::from(rect.height) * scale).round() as u32;

viuer::print(
match viuer::print(
image,
&viuer::Config {
x: rect.x,
@@ -386,10 +386,12 @@ fn render_playback_cover_image(state: &SharedState, ui: &mut UIStateGuard) -> Re
transparent: true,
..Default::default()
},
)
.context("print image to the terminal")?;

ui.last_cover_image_render_info.rendered = true;
) {
Err(e) => anyhow::bail!("failed to print image to the terminal, error: {e}"),
Ok(_) => {
ui.last_cover_image_render_info.rendered = true;
}
}
}

Ok(())