Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-3404] Correct the description about MySQL usage #48

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

klion26
Copy link
Member

@klion26 klion26 commented Jan 21, 2025

The lincense of MySQL is incompatible with Apache Lincese, we need to correct the descriptions

This closes apache/amoro#3404

@klion26
Copy link
Member Author

klion26 commented Jan 21, 2025

@justinmclean @zhoujinsong please help to review this when you're free, thanks.

The lincense of MySQL is incompatible with Apache Lincese, we need to correct the descriptions

This closes apache/amoro#3404
@klion26 klion26 force-pushed the correct-mysql-usage-desc branch from 2766fce to a053083 Compare January 21, 2025 03:44
Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@klion26 Thanks for the work!

I left some comments, PTAL.

amoro-docs/content/admin-guides/deployment.md Outdated Show resolved Hide resolved
@klion26 klion26 requested a review from zhoujinsong January 21, 2025 05:56
@klion26
Copy link
Member Author

klion26 commented Jan 21, 2025

@zhoujinsong comments have been addressed, please take another look when you're free, thanks.

Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

You may want to copy the changes to the main repo.

actually, we manage the docs in the main repo and copied to the site repo when we released a new version.

@zhoujinsong zhoujinsong merged commit 3351936 into master Jan 22, 2025
3 checks passed
@zhoujinsong zhoujinsong deleted the correct-mysql-usage-desc branch January 22, 2025 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: Correct the documentation for MySQL usage
2 participants