allow to override Base(Large)RepeatedValueViewVector #488
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done as different arrow implementation have different default list item field name
For example, Rust implementation of Arrow (
arrow-rs
) has default value ofitem
(https://github.com/apache/arrow-rs/blob/4f1f6e57c568fae8233ab9da7d7c7acdaea4112a/arrow-schema/src/field.rs#L125).And according to the specification, the name of the list is not required to be a specific string. so to make it easier to use Java Arrow implementation with other implementation of Arrow, I'm making the
DATA_VECTOR_NAME
configurableI will add tests after I know this change is desired and will be approved
Another solution that is good for me, is to allow changing the field name of existing list (as sometimes I'm not the one that creates the list but all the lists are coming through me, currently it is not possible as far as I can tell.
the only place I see in the codebase that do something like that is in:
arrow-java/vector/src/test/java/org/apache/arrow/vector/pojo/TestConvert.java
Line 97 in be627bf
which convert the schema to json, change the field name and create the schema again (making sure the new field name is used)