Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Data type inference for NaN, inf and -inf in csv files #7150

Merged
merged 3 commits into from
Feb 19, 2025
Merged

fix: Data type inference for NaN, inf and -inf in csv files #7150

merged 3 commits into from
Feb 19, 2025

Conversation

Mottl
Copy link
Contributor

@Mottl Mottl commented Feb 18, 2025

Which issue does this PR close?

Closes #7149

Rationale for this change

NaN, inf and -inf will be inferred as Float64, not Utf8 as of now

@github-actions github-actions bot added the arrow Changes to the arrow crate label Feb 18, 2025
tustvold
tustvold reviewed Feb 18, 2025
View reviewed changes
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs some tests

@tustvold
Copy link
Contributor

I think this counts as a bug fix and therefore not a breaking change, but I wonder if anyone feels differently?

@alamb @etseidl ?

alamb
alamb approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- I agree this is a bug fix and can be included in a minor release

@alamb
Copy link
Contributor

alamb commented Feb 19, 2025

Thanks for the review @tustvold

@tustvold tustvold merged commit 7b057e1 into apache:main Feb 19, 2025
23 checks passed
friendlymatthew pushed a commit to friendlymatthew/arrow-rs that referenced this pull request Feb 21, 2025
@Mottl @friendlymatthew
fix: Data type inference for NaN, inf and -inf in csv files (apache#7150
8a69862 
)

* fix: Data type inference for NaN, inf and -inf in csv files

* Adds tests for NaN, inf and -inf Float64 values

* Adds python-style NaN
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

@tustvold tustvold tustvold approved these changes

Assignees
No one assigned
Labels
arrow Changes to the arrow crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improper data type inference for NaN, inf and -inf in csv files
3 participants
@Mottl @tustvold @alamb